Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed rdflib-jsonld as a dependency #182

Closed
wants to merge 3 commits into from
Closed

Removed rdflib-jsonld as a dependency #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d445d38
Removed rdflib-jsonld as a dependency
BryceStevenWilley Sep 19, 2021
f6251fa
Conditionally required rdflib-jsonld when py < 3.6
BryceStevenWilley Sep 29, 2021
5274995
Enforce lower version of jsonld in setup.py
BryceStevenWilley Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
# pip install -r requirements.txt
lxml
requests
rdflib
rdflib-jsonld
rdflib>=6.0.1; python_version>="3.7"
rdflib<6.0.0; python_version<"3.7"
Comment on lines +5 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a limbo here for version 6.0.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's intentional: rdflib 5.0.0 is the latest available on python 3.6 and lower, and rdflib 6.0.1 is the latest available on python 3.7, there's no good reason you would need to stick with 6.0.0, which still requires the use of rdflib-jsonld.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no good reason you would need to stick with 6.0.0, which still requires the use of rdflib-jsonld.

I don't think 6.0.0 requires rdflib-jsonld, see https://github.com/RDFLib/rdflib/blob/6.0.0/setup.py - so if 6.0.0 works fine for us, I'd rather not disallow it. Since extruct is a library, it makes sense to not be overly strict with what we require, to avoid conflicts with requirements of other packages.

rdflib-jsonld<=0.5.0; python_version<"3.7"
pyrdfa3
mf2py>=1.1.0
six>=1.11
Expand Down
6 changes: 4 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ def get_version():
packages=find_packages(exclude=['tests',]),
package_data={'extruct': ['VERSION']},
install_requires=['lxml',
'rdflib',
'rdflib-jsonld',
'rdflib<6.0.0;python_version<"3.7"',
'rdflib-jsonld<=0.5.0;python_version<"3.7"',
# rdflib 6.x.y (only on 3.7 and up) contains jsonld
'rdflib>=6.0.1;python_version>="3.7"',
'pyrdfa3',
'mf2py',
'w3lib',
Expand Down