Removed rdflib-jsonld as a dependency (from GH-182) #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using environment markers in setup.py: https://www.python.org/dev/peps/pep-0508/#environment-markers
Co-authored-by: Konstantin Lopuhin <kostia.lopuhin@gmail.com>
This reverts commit 960ca66. The reason why it's needed is that in tox, we write conditions like [testenv:py38], but this does not apply to "tox -e py" as the environment name is different. I wonder what is the proper way to do this?
lopuhin
force-pushed
the
gh-182-build
branch
from
f77c458
to
a19d2f1
Compare
BryceStevenWilley
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Looks good to me! (though I'm not an expert at tox).
I'd be okay with merging this over #182 and just closing that PR.
lopuhin
changed the title
There are no major changes in 6.0.1, we should not be too strict as a library here.
|
Great, thank you @BryceStevenWilley - I only made a small change on top of your PR, following the discussion in #182 (comment) - it seems we'd be also fine with 6.0.0 for newer python, so we no longer disallow it. @Gallaecio would you mind having another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #182, thanks @BryceStevenWilley