Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of how to run start-crawl in docker #410

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

ejulio
Copy link
Contributor

@ejulio ejulio commented Oct 1, 2021

docs/conf.py Outdated Show resolved Hide resolved
docs/deploy-custom-image.rst Outdated Show resolved Hide resolved
docs/deploy-custom-image.rst Outdated Show resolved Hide resolved
docs/deploy-custom-image.rst Outdated Show resolved Hide resolved
docs/deploy-custom-image.rst Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
@ejulio
Copy link
Contributor Author

ejulio commented Oct 4, 2021

@Gallaecio thanks for checking this one.
I've rolled back the docs changes and updated the text as you asked

docs/conf.py Outdated Show resolved Hide resolved
@pawelmhm
Copy link
Member

Thanks for adding this documentation!

Only problem I see is that commands needed to actually run container are quite complex, is there no way to somehow change architecture in a way that makes it possible to run container the same way as in Cloud locally with just one step? Or maybe add some separate library, shub-zyte-cloud where people can go and run someone single command like "make" or "please" and it will launch things. This is just an idea though, this documentation improvement looks very good on its own

@ejulio
Copy link
Contributor Author

ejulio commented Nov 30, 2021

Hey @pawelmhm , I'll leave your comment hanging around on my notes.
I believe there could be a way to do something like that, but I'm not sure

@ejulio
Copy link
Contributor Author

ejulio commented Nov 30, 2021

@Gallaecio can you merge this one? I don't have proper access :(

@elacuesta elacuesta merged commit 5fcb15f into scrapinghub:master Dec 2, 2021
@ejulio ejulio deleted the update-docker-docs branch December 2, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants