Allow click versions other than 7.0 #416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 89.52% 89.54% +0.02%
==========================================
Files 34 34
Lines 2415 2420 +5
==========================================
+ Hits 2162 2167 +5
Misses 253 253
Continue to review full report at Codecov.
|
shub/utils.py
Outdated
| @@ -830,6 +845,6 @@ def create_scrapinghub_yml_wizard(conf, target='default', image=None): | |||
| if image or (image is None and _detect_custom_image_project()): | |||
| repository = click.prompt( | |||
| "Image repository (leave empty to use Scrapinghub's repository)", | |||
| default=True, show_default=False) | |||
| default=True, show_default=False, type=_BooleanOrStringParamType()) | |||
There was a problem hiding this comment.
This was failing since click 8.0.1, specifically since pallets/click@ad52b19, which due to default=True was converting string inputs to True as well.
| [testenv:min] | ||
| deps = | ||
| {[testenv]deps} | ||
| -r requirements.txt |
There was a problem hiding this comment.
A separate Tox environment to test those “minimum” versions of dependencies, while keeping the rest of the Tox environments testing the latest versions of dependencies.
|
When this PR will be merged? |
Fixes #404