Skip to content

Commit

Permalink
The .start_listening() method should be called but...
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss authored Feb 17, 2024
1 parent ef571a5 commit cd9b51d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/test_extension_telnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ def test_without_start_Lintening(self):
"""
Calls are made in an incorrect order so `self.port` is never initialized.
Class variables should be initialized in the .__init__() method but .port
is not. This raises a NameError as discussed in scrapy/scrapy#2702
is not. This raises an AttributeError as discussed in scrapy/scrapy#2702
"""
telnet_console = TelnetConsole(crawler=get_crawler())
# The .start_listening() should be called but humans are imperfect.
# .start_listening() method should be called but developers are imperfect
# telnet_console.start_listening()
with self.assertRaises(
AttributeError, msg="'TelnetConsole' object has no attribute 'port'"
Expand Down

0 comments on commit cd9b51d

Please sign in to comment.