-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.7 support #3143
Comments
One issue was reported at https://stackoverflow.com/questions/48861287/why-am-i-getting-this-error-in-scrapy-python3-7-invalid-syntax
This also happens if Twisted issue: https://twistedmatrix.com/trac/ticket/9384#ticket and PR twisted/twisted#966 |
Is this an issue that needs someone to work on? I would love to give it a shot. :-) Looks like the PR to fix the above issue should be merged soon. |
@patiences yes, I'm not aware of anyone working on it, so it would be awesome if you give it a shot! And feel free to submit a work in progress PR. I think first step would be adding python 3.7 to tox and travis. There might be other issues besides this syntax error in twisted. |
I once thought it supported Python3.7,in other words, was it support Python3.6-? |
Scrapy supports Python 3.6, and Travis has related tests. |
It seems like this issue is dependent on twisted/twisted#966 to be merged in first. |
I have reopened this issue. The problem persists. |
@jstnms123 I don't think this issue was ever closed, just the referenced issue since it was a duplicate. @lopuhin do you know of a current workaround to install the branch you created in twisted so scrapy can run with 3.7? (twisted/twisted#966) |
@illgitthat you can install the branch with |
Thank you @lopuhin! I googled around but I must have been just off on the syntax. |
@lopuhin -- I used the work around to appropriate effect. Thanks for the info. jA |
thanks @lopuhin pip install git+https://github.com/lopuhin/twisted.git@9384-remove-async-param |
pip install git+https://github.com/lopuhin/twisted.git@9384-remove-async-param fails for me on Windows but worked on Linux. I think this is related to a twisted issue not scrapy, just leaving this here in case anyone else on Windows is stuck trying to run scrapy on 3.7. |
FWIW, thanks to awesome Twisted maintainers, the fix in twisted/twisted#966 was finished and merged into Twisted, so it should be in the next Twisted release. Also a workaround for this issue was merged into scrapy master (and will be in the 1.6 release), so another way to enable python 3.7 support right now, is to install scrapy master and use Twisted from PyPI. |
Using Thanks for the help. |
Yup @illgitthat works for me; I think @lopuhin branch might be merged in now, so it's gone |
Ummm just replace the word async with isAsync the other is deprecated.... |
@joshspivey |
Go to Python37\Lib\site-packages\twisted\conch edit "manhole" file and replace the 'async' parameter by 'isAsync'. |
Because I was just trying this out in a new project, @illgitthat 's solution didn't work for me. |
Thank you to all of you guys, the command |
This also worked for me. Thank you very much. |
Also adding in that the current fix for this is running Thank you everyone! |
Getting error on crawl |
same issue as AsthaSrivastava8 post. any solution now ? |
Installed scrapy via Python = 3.7.0 Is there a temporary workaround? |
@appcypher As far as I understood the developers: Install from the repository directly, because it seems they implemented a workaround which was not released, yet. See above: #3143 (comment) |
@appcypher via pipenv install scrapy==1.5.1
pipenv shell
pip install git+https://github.com/scrapy/scrapy@master --no-dependencies --upgrade |
worked for me. |
just use python 2.7, problem solved |
Hi Lopuhin, it gives me path error, what i do? |
hi @ruchi3086 since this was merged and released, now you can do |
Hi There,
Great to have the immediate reply, which I was actually looking for....
The primary problem is:
[image: image.png]
How may I solve this please??
Thanks
Ruchi
…On Wed, Sep 25, 2019 at 9:32 AM Konstantin Lopuhin ***@***.***> wrote:
hi @ruchi3086 <https://github.com/ruchi3086> since this was merged and
released, now you can do pip install scrapy or pip3 install scrapy. If
this still gives you an error, please paste it here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3143?email_source=notifications&email_token=AK6SYFG64EUKS2IMHFLCKN3QLMH2LA5CNFSM4ESOCKG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7Q5BOY#issuecomment-534892731>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK6SYFDUUX42YVUDFCY6LP3QLMH2LANCNFSM4ESOCKGQ>
.
--
Best regards,
Ruchi Gupta
|
Traceback (most recent call last): |
@ruchi3086 most likely you need to rename Note though that this is no longer related to python 3.7 support and most likely not a scrapy bug, please, use StackOverflow to ask this type of questions. See Getting Help. |
I'm still having the original issue. None of the proposed workarounds seem to make any difference. |
The original issue is Python 3.7 support. If you have a different issue, and you believe it is a Scrapy bug rather than an error in your end, please open a separate issue. |
I deleted my comment because I realized my misstake. Apologies for this |
The goal is to add python 3.7 to travis and pass all tests, the first beta was already released at the end of January.
The text was updated successfully, but these errors were encountered: