Remove deprecated Spider.make_requests_from_url method

[elacuesta]

As mentioned in #4170 (comment)

This method was deprecated in #1728, released in 1.4.0

Should we also remove scrapy.utils.deprecate.method_is_overridden? It was introduced in the above PR and it's not currently used anywhere else, but I think its purpose is still valid.

Closes #4356

[codecov]

Codecov Report

Merging #4178 (d63cc68) into master (5a75b14) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d63cc68 differs from pull request most recent head 91f8144. Consider uploading reports for the commit 91f8144 to get more accurate results

@@            Coverage Diff             @@
##           master    #4178      +/-   ##
==========================================
- Coverage   88.09%   88.07%   -0.02%     
==========================================
  Files         162      162              
  Lines       10345    10335      -10     
  Branches     1504     1502       -2     
==========================================
- Hits         9113     9103      -10     
  Misses        964      964              
  Partials      268      268              

Impacted Files	Coverage Δ
scrapy/spiders/__init__.py	100.00% <100.00%> (ø)

[Gallaecio]

Should we also remove scrapy.utils.deprecate.method_is_overridden?

Maybe deprecate it first, just in case?

[elacuesta]

Makes sense, but just to be clear, it's not that I want to remove it. I actually think it's still valid and we might need it at some point.
I figured that since the function is not used anymore after this change, a discussion about its removal would start and I thought it would be faster if I just raised the question to begin with - Perhaps it was too much early optimization 😅

[Gallaecio]

OK, I guess we can leave that for a separate ticket.

[nyov]

And it hasn't been properly deprecated in Scrapy 2.0, either? 😭

I hope it might be ready for removal at the big anniversary (1.4.0 > 2.4.0), so we can close this in 2024ish? ;)
I hope this will work: #4412

[wRAR]

What's the status of this?

[kmike]

I think we should aim to remove this method 1 year after the release which contains #4412, as per https://docs.scrapy.org/en/master/versioning.html#deprecation-policy.

It looks like this release was Scrapy 2.1 which happened 2020-04-24, so we should be waiting until April 2021 before merging this (assuming there is going to be a release in May).