Handle HTTP 308 Permanent Redirect #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangra
reviewed
Jul 24, 2017
| @@ -42,6 +42,10 @@ def _test(method): | |||
| _test('POST') | |||
| _test('HEAD') | |||
|
|
|||
| _test('GET', status=308) | |||
| _test('POST', status=308) | |||
| _test('HEAD', status=308) | |||
There was a problem hiding this comment.
tests are fine but looks like a good opportunity to add tests for 307 status too
Codecov Report
@@ Coverage Diff @@
## master #2847 +/- ##
======================================
Coverage 84.7% 84.7%
======================================
Files 163 163
Lines 9191 9191
Branches 1367 1367
======================================
Hits 7785 7785
Misses 1154 1154
Partials 252 252
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2844