Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable unnecessary-comprehension and use-dict-literal pylint tags #6257

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix and re-enable unnecessary-comprehension and use-dict-literal pylint tags #6257

merged 2 commits into from
Feb 29, 2024

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Feb 28, 2024

Fixes #6254

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited
Loading

Codecov Report

Merging #6257 (26a16f2) into master (532cc8a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6257   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files         161      161           
  Lines       11776    11776           
  Branches     1914     1913    -1     
=======================================
  Hits        10468    10468           
  Misses        964      964           
  Partials      344      344
Files Coverage Δ
scrapy/downloadermiddlewares/httpcompression.py 91.07% <100.00%> (ø)
scrapy/spiders/crawl.py 96.55% <ø> (ø)
scrapy/utils/python.py 88.53% <100.00%> (ø)

@Laerte Laerte requested a review from wRAR February 28, 2024 20:14
wRAR
wRAR approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@wRAR wRAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wRAR wRAR merged commit 198f5cf into scrapy:master Feb 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and re-enable unnecessary-comprehension and use-dict-literal pylint tags
2 participants
@Laerte @wRAR