Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for release #87

Merged
merged 13 commits into from
Oct 1, 2021
Merged

Prepare for release #87

merged 13 commits into from
Oct 1, 2021

Conversation

jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented Sep 23, 2021 •
edited
Loading

closes #84

@jpmckinney
docs: Move scrapyd-client after scrapyd-deploy. Add badges.
1c26469
@jpmckinney
chore: Remove "from __future__ import print_function" for unsupported…
cd6055c 
… versions
@jpmckinney
build: Remove setup.cfg as the package is no longer universal (no Pyt…
0679231 
…hon 2)
@jpmckinney
build: Update MANIFEST.in and run check-manifest in GitHub Actions
e2e8804
@jpmckinney
build: Rewrite setup.py
86d0ed1 
- Add direct dependency on w3lib
- Add test dependency on pytest-cov
- Add classifiers to match Scrapy
- Run flake8 on all files
- Generate coverage during pytest
- Use unittest.mock instead of mock
- Move test requirements to setup.py, instead of requirements-dev.txt or tox.ini
@jpmckinney
ci: Generate coverage report in XML format for Codecov
4a1c6ca
@codecov
Copy link

codecov bot commented Sep 23, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ede5f0b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage          ?   60.60%           
=========================================
  Files             ?        5           
  Lines             ?      363           
  Branches          ?        0           
=========================================
  Hits              ?      220           
  Misses            ?      143           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede5f0b...cd4b087. Read the comment docs.

@jpmckinney
Copy link
Contributor Author

Requesting review prior to tagging for release. I removed .bumpversion.cfg because it automatically creates tags, which I find very undesirable as it can accidentally push versions to PyPI. Changing the number in VERSION is easy enough.

@jpmckinney
Copy link
Contributor Author

Note: Publication to TestPyPI is failing because the TEST_PYPI_TOKEN secret isn't set. In my own projects, I set this organization-wide, so that all packages, on every build, can test publication to PyPI.

The workflow also needs a PYPI_TOKEN secret.

pawelmhm
pawelmhm reviewed Sep 23, 2021
View reviewed changes
README.rst Outdated Show resolved Hide resolved
Gallaecio
Gallaecio reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

setup.py Outdated Show resolved Hide resolved
pawelmhm
pawelmhm approved these changes Sep 23, 2021
View reviewed changes
Copy link

@pawelmhm pawelmhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks @jpmckinney for keeping project alive 👍

@jpmckinney
Copy link
Contributor Author

Thanks for the review! The comments have been integrated.

I also added a commit to include the changelog on PyPI, similar in approach to https://github.com/scrapy/parsel/blob/master/setup.py.

@Gallaecio
Copy link
Member

TEST_PYPI_TOKEN defined, restarting tests…

@Gallaecio
Copy link
Member

@jpmckinney Feel free to merge

@jpmckinney jpmckinney merged commit 3772ef5 into master Oct 1, 2021
@jpmckinney jpmckinney deleted the prepare-release branch October 1, 2021 15:10
@jpmckinney
Copy link
Contributor Author

1.2.0 is on PyPI 🚀 https://pypi.org/project/scrapyd-client/

@jpmckinney jpmckinney mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@pawelmhm pawelmhm pawelmhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy to PyPI in GitHub Actions
3 participants
@jpmckinney @Gallaecio @pawelmhm