Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url_query_cleaner and fragments #60

Closed
csalazar opened this issue Jul 7, 2016 · 1 comment
Closed

url_query_cleaner and fragments #60

csalazar opened this issue Jul 7, 2016 · 1 comment

Comments

@csalazar
Copy link

csalazar commented Jul 7, 2016

Hi guys, why url_query_cleaner removes the fragment part? Is it expected?

In [5]: url_query_cleaner('http://domain.tld/?bla=123#123123', ['bla'], remove=True)
Out[5]: 'http://domain.tld/'
@starrify
Copy link
Contributor

starrify commented Sep 8, 2016

Is it expected?

Yes. The URL would be explicitly defragmented at line 204 of url.py:

url = urldefrag(url)[0]

@redapple redapple mentioned this issue Sep 13, 2016
Merged
@kmike kmike closed this as completed in 36cbdc2 Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csalazar @starrify