Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio to Screego #102

Closed
wants to merge 2 commits into from
Closed

Conversation

aydenbottos
Copy link

Yes, the whole idea of Screego is to be as simple as possible, but I think the project could benefit from this. Attached are 2 commits that add simple microphone support. Note that these weren't made by me, but rather @L11r. They are older but have no conflicts against upstream.

@BroderPeters
Copy link
Contributor

BroderPeters commented Aug 31, 2021

Screego tries to do one thing well and that is screen sharing. It may seem easy
to just add another video stream, and it probably is. But the cost of
maintaining it isn't worth for me. The next feature request would probably be
microphone support and with that Screego would be competing with services like
jitsi or big blue button and I see no way that I as a solo developer
can do a better job than these projects.

#66 (comment)
Not sure if the maintainer opinion on that changed recently.

@aydenbottos
Copy link
Author

Not sure either. If not, I would be happy to fork and rebase when upstream is updated. A second branch could also be an option.

@savely-krasovsky
Copy link

Also notice that I had to change Docker image name in order to build binaries and release with Github Actions CI/CD. It's was not intended to be merged sometime. I am not a frontend developer, so my edits probably bad or kinda, someone with right hands should review it and probably rework.

@aydenbottos
Copy link
Author

aydenbottos commented Aug 31, 2021 via email

@jmattheis
Copy link
Member

In the current state, I cannot merge it. The mute button is always visible, even if there's no audio stream and the user cannot decide not to share audio. Screego was never intended to stream audio, thus, it needs to be opt-in.

@aydenbottos
Copy link
Author

aydenbottos commented Sep 2, 2021 via email

@jmattheis
Copy link
Member

When a user starts to present, there is an option to share tab audio.

But only the first time, if the user allows it, is most likely saved for future requests.

The following things are required for this PR to be merged. (I'll close it for now, because it is not ready)

  • The mute button must be hidden, if the other user doesn't share the video with audio.
  • There needs to be a separate button or dropdown. "Start presentation with audio" which is only visible if audio sharing is supported by the browser.
  • The renames of the docker image names but be reverted.

@jmattheis jmattheis closed this Oct 26, 2021
@strvert strvert mentioned this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants