-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio to Screego #102
Add audio to Screego #102
Conversation
Fix panic if no ports are available
#66 (comment) |
Not sure either. If not, I would be happy to fork and rebase when upstream is updated. A second branch could also be an option. |
Also notice that I had to change Docker image name in order to build binaries and release with Github Actions CI/CD. It's was not intended to be merged sometime. I am not a frontend developer, so my edits probably bad or kinda, someone with right hands should review it and probably rework. |
I can have a look sometime although I am not really the best person for the
job either!
[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality7&>
Sender
notified by Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality7&>
08/31/21,
09:41:18 PM
…On Tue, Aug 31, 2021 at 9:20 PM Savely Krasovsky ***@***.***> wrote:
Also notice that I had to change Docker image name in order to build
binaries and release with Github Actions CI/CD. It's was not intended to be
merged sometime. I am not a frontend developer, so my edits probably bad or
kinda, someone with right hands should review it and probably rework.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#102 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHNAJAZ7ZTKRHX6GSNXFTFLT7S3G3ANCNFSM5DDKYU2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
In the current state, I cannot merge it. The mute button is always visible, even if there's no audio stream and the user cannot decide not to share audio. Screego was never intended to stream audio, thus, it needs to be opt-in. |
When a user starts to present, there is an option to share tab audio. The
mute button only controls the local audio and allows a user to mute
the audio of the stream they are watching.
[image: Mailtrack]
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality9&>
Sender
notified by
Mailtrack
<https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality9&>
09/03/21,
09:41:58 AM
…On Fri, Sep 3, 2021 at 2:02 AM Jannis Mattheis ***@***.***> wrote:
In the current state, I cannot merge it. The mute button is always
visible, even if there's no audio stream and the user cannot decide not to
share audio. Screego was never intended to stream audio, thus, it needs to
be opt-in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#102 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHNAJA3FJIZCP64GGNUPT6LT76N2LANCNFSM5DDKYU2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
But only the first time, if the user allows it, is most likely saved for future requests. The following things are required for this PR to be merged. (I'll close it for now, because it is not ready)
|
Yes, the whole idea of Screego is to be as simple as possible, but I think the project could benefit from this. Attached are 2 commits that add simple microphone support. Note that these weren't made by me, but rather @L11r. They are older but have no conflicts against upstream.