Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Profile Memory #21

Open
RiftLurker opened this issue May 17, 2017 · 1 comment
Open

[Feature] Profile Memory #21

RiftLurker opened this issue May 17, 2017 · 1 comment

Comments

@RiftLurker
Copy link
Contributor

It's currently not possible to profile Memory deserialization cost, because the Profiler accesses (and therefor deserializes) Memory when checking if it should be profiling.

This can be solved in one of the following ways:

  • Add an option to profile Memory deserialization
  • Provide a function wrapper that doesn't check if the profiler is enabled
@gdborton
Copy link
Collaborator

I've been meaning to add this by default, and probably log a warning if it thinks you might have accessed memory before enabling the profiler. This can be done pretty simply by timing access to Memory very early on in the profiler's logic, logging if that access takes < ~2ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants