Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlackArch Linux support #315

Merged
merged 8 commits into from Oct 22, 2018
Merged

BlackArch Linux support #315

merged 8 commits into from Oct 22, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 23, 2018

Now, TheFatRat support BlackArch Linux too! :)

@peterpt
Copy link
Collaborator

peterpt commented Oct 2, 2018

If that request is merged then debian users will not able to install the packages that you changed to pacman unless they install pacman on debian .
Doing a witch apt-get and if not present then a switch to use pacman is the solution , because this way both distribution will be able to install the tool .
At least this is my opinion after i saw the changes in setup.sh .
In some distributions apache could be with the name httpd , but in a server i have here with debian 9 it is apache2 .
setup will probably be changed to call all 3 , this means if apache not found then check for apache2 , and if apache2 is not found then check httpd , and depending on what exists then setup will write in the config file , if none exists then it will popup a message saying that apache2 was not found .

I have to do a large revision in the setup.sh , i will see if next weekend i do that .

/usr/bin/systemctl should not be used by the fact that if linux distribution is not a systemd then that call will pop an error on file not found .
I believe /etc/init.d/service start is still the best way do deal with 2 ltypes of linux distributions .

@ghost
Copy link
Author

ghost commented Oct 3, 2018

@peterpt hmm, go deeper in setup.sh: I use || for apt-get and pacman install commands. And setup.sh do any changes in /etc/apt/sources.list only if we on Debian-based OS (simple verification: which pacman). I understand that not the most elegant decision, but if you have offers, write it. Also, I install TheFatRat with this changes on Kali Rolling without any problem and it's work perfectly.

@ghost
Copy link
Author

ghost commented Oct 3, 2018

Doing a witch apt-get and if not present then a switch to use pacman is the solution , because this way both distribution will be able to install the tool .

@peterpt firstly I do this, but after, I think what it can make code harder to read. And then, I choose || contruction, because it more small and easier.

@screetsec screetsec merged commit c6081fa into screetsec:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants