Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(399): Sending build ids as strings not numbers #12

Merged
merged 1 commit into from
Dec 23, 2016
Merged

fix(399): Sending build ids as strings not numbers #12

merged 1 commit into from
Dec 23, 2016

Conversation

stjohnjohnson
Copy link
Contributor

@stjohnjohnson stjohnjohnson commented Dec 22, 2016 •
edited
Loading

This was causing Docker to fail with cannot unmarshal number into Go value of type string

Epic: screwdriver-cd/screwdriver#399

petey
petey approved these changes Dec 22, 2016
View reviewed changes
Copy link
Contributor

@petey petey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha___

@d2lam
Copy link
Member

d2lam commented Dec 22, 2016

Can you also change the comment for the function. For ex: here

@stjohnjohnson
Copy link
Contributor Author

@d2lam please re-review

d2lam
d2lam approved these changes Dec 23, 2016
View reviewed changes
Copy link
Member

@d2lam d2lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

@d2lam d2lam merged commit 0137dc8 into master Dec 23, 2016
@d2lam d2lam deleted the StringsNotNumber branch December 23, 2016 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2lam d2lam d2lam approved these changes

@petey petey petey approved these changes

Assignees
No one assigned
Labels
change/patch priority/high type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stjohnjohnson @d2lam @petey