fix(1839): Pass timeout value from build config to container #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithine
reviewed
Jan 13, 2020
| @@ -129,6 +129,9 @@ class DockerExecutor extends Executor { | |||
| const piecesParts = imageParser(config.container); | |||
| let buildTag = piecesParts.tag; | |||
| let buildImage = piecesParts.name; | |||
| const buildTimeout = hoek.reach(config, 'annotations>screwdriver.cd/timeout', | |||
There was a problem hiding this comment.
you can use this function to grab the value from annotations https://github.com/screwdriver-cd/executor-base/blob/master/index.js#L198
There was a problem hiding this comment.
you can use this
functionto grab the value from annotations https://github.com/screwdriver-cd/executor-base/blob/master/index.js#L198
doesn't seem generic, the function parses all annotations. Will probably need to write another helper function which can take a key
jithine
approved these changes
Jan 15, 2020
tkyi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The timeout annotations set by user for a job is not being passed to the container currently and it uses the default timeout.
Objective
This PR will parse the annotations for timeout value or use default timeout and pass to the container for timeout to work correctly
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.