feat(1285): Add endpoint for stopping all builds in an event #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DekusDenial
approved these changes
Apr 19, 2019
There was a problem hiding this comment.
LGTM overall. Recently I saw https://hapijs.com/api#-routeoptionspre and I do see a lot of user authz logic being repeated. Shamefully I did c&p one time and was meh 🤷♂️ . Hope it may seem refactorable to you at some point.
d2lam
reviewed
Apr 19, 2019
plugins/events/stopBuilds.js
Outdated
| } | ||
|
|
||
| // PR author should be able to stop their own PR build | ||
| if (event.prNum && isPrOwner) { |
There was a problem hiding this comment.
we can combine || adminDetails.isAdmin here and resolve
d2lam
reviewed
Apr 19, 2019
plugins/events/stopBuilds.js
Outdated
| permissions = userPermissions; | ||
|
|
||
| // Check if user has push access or is a Screwdriver admin | ||
| if (permissions.push || adminDetails.isAdmin) { |
There was a problem hiding this comment.
I think we can remove this block updateAdmins will do the adding/removing good/bad admins and resolves/throw
vnugopal
approved these changes
Apr 19, 2019
vnugopal
reviewed
Apr 19, 2019
d2lam
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It can be annoying for users to have to manually stop each build in an event. It would be nice if they could stop all running/queued/blocked builds with one click or API call.
Objective
This PR adds an endpoint that checks/updates user permissions and gets all running/queued/blocked builds for an event and updates the status to
ABORTED.Note: The endpoint is currently a
PUT /events/{id}/stop, but open to any ideas.Wondering if
/events/{id}/builds/stopor/events/{id}/builds/stopallwould be better. Or aPOST?This PR also does some light refactoring, moving the
updateAdminsfunction intoevents/index.js.References
Related to #1285