[4] fix(1755): Add baseBranch to event and build config #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2019
yoshwata
approved these changes
Oct 1, 2019
sugarnaoming
approved these changes
Oct 1, 2019
tkyi
reviewed
Oct 2, 2019
plugins/builds/index.js
Outdated
| jobName, username, scmContext, build, start }) { | ||
| async function createBuild(config) { | ||
| const { jobFactory, buildFactory, eventFactory, pipelineId, jobName, | ||
| username, scmContext, build, start } = config; |
There was a problem hiding this comment.
Suggested change
| username, scmContext, build, start } = config; | |
| username, scmContext, build, start, baseBranch } = config; |
tkyi
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To use branch info in the restarted build and triggered build, I added branch info to event and build config when they are created. And use that info when creating new event.
PR build was failed because related PRs are not merged.
It may success after related PRs will be merged.
Objective
References
#1755
#1760
Related PRs:
screwdriver-cd/data-schema#357
screwdriver-cd/models#396
screwdriver-cd/scm-base#72
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.