Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2026): Check for startFrom for event create [2] #2027

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Conversation

tkyi
Copy link
Member

@tkyi tkyi commented Mar 16, 2020

Context

Should throw a more specific error when startFrom is missing.
startFrom is not required when buildId is passed in.

Objective

This PR adds a check for startFrom.

References

Related to #2026

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 97.058% when pulling 671423d on fixStartFrom into c033862 on master.

@tkyi tkyi merged commit 37db5db into master Mar 16, 2020
@tkyi tkyi deleted the fixStartFrom branch March 16, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants