Skip to content

Conversation

miend
Copy link
Contributor

@miend miend commented Oct 14, 2022

Using Terraform 1.3.2, this module seems to work just as expected, all resources created fine. I can see no breaking changes between tf 1.2 and 1.3 which should affect this. This will relax the requirements to allow any 1.3.x to be used.

@miend
Copy link
Contributor Author

miend commented Oct 20, 2022

A ping for review by @jim80net -- thanks 👍

@nogweii
Copy link

nogweii commented Nov 30, 2022

We're running into this, too. Friendly ping to someone at Scribd. 😄

@call
Copy link

call commented Jan 6, 2023

Yes please, can we get this merged Scribd team 🙏 Thank you. cc @jim80net

@jim80net jim80net merged commit 1d4c786 into scribd:master Jan 26, 2023
@jim80net
Copy link
Contributor

Apologies for the delay in merge. Thanks everyone for your submission and comments!

github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
# [3.1.0](v3.0.0...v3.1.0) (2023-01-26)

### Features

* enable support for Terraform 1.3.x ([#51](#51)) ([1d4c786](1d4c786))
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dtw45
Copy link

dtw45 commented May 9, 2023

Hey @jim80net, it's pretty uncommon for modules to specify a cap on the required Terraform version, normally they only enforce a minimum. (Any of the aws managed Terraform modules should serve as an example)

Specifying a cap blocks users from upgrading to newer versions and requires that these small PRs are opened and reviewed every time a new version of Terraform is released. Would you guys consider only enforcing a minimum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants