Skip to content

Update to 1.21 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 21, 2024
Merged

Update to 1.21 #22

merged 12 commits into from
Jun 21, 2024

Conversation

Smalldero
Copy link
Contributor

Version changes

Some changes to the AbstractMinecartEntityMixin

  • The hasCustomName seems to be gone, so I manually check for a custom name
  • The moveToWorld was replaced with teleportTo

@scriptcoded
Copy link
Owner

Closes #20

scriptcoded
scriptcoded approved these changes Jun 21, 2024
View reviewed changes
Copy link
Owner

@scriptcoded scriptcoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This seems to work pretty well. I discovered a bug where the minecart didn't keep its name when teleporting through a portal. I added a fix for this on your branch.

I'll quash and merge this. Thanks a lot! 🙏

@scriptcoded scriptcoded merged commit ddbe1d4 into scriptcoded:main Jun 21, 2024
@github-actions github-actions bot mentioned this pull request Jun 21, 2024
Merged
@Smalldero
Copy link
Contributor Author

Awesome, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scriptcoded scriptcoded scriptcoded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smalldero @scriptcoded