Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Exit codes from scriptcs.exe are not propagated #67

Closed
adamralph opened this issue Mar 28, 2015 · 5 comments
Closed

Exit codes from scriptcs.exe are not propagated #67

adamralph opened this issue Mar 28, 2015 · 5 comments
Labels
Milestone

Comments

@adamralph
Copy link
Contributor

It seems as though svm always returns a zero exit code, even if scriptcs.exe returns something else.

This tripped me up to today whilst writing a script pack test automation app.

paulbouwer added a commit to paulbouwer/svm that referenced this issue Mar 30, 2015
paulbouwer added a commit that referenced this issue Mar 30, 2015
Issue #67 - Exit codes from scriptcs.exe are not propagated
@paulbouwer
Copy link
Contributor

Fixed in ebd9aec. It was only an issue in the Windows version, but has also been tested on Linux.

c:\ > scriptcs a.csx
ERROR: Could not find file 'C:\a.csx'. - 'C:\a.csx'.

c:\ > echo %errorlevel%
1

c:\> scriptcs -v
               _       _
 ___  ___ _ __(_)_ __ | |__ ___ ___
/ __|/ __| '__| | '_ \| __// __/ __|
\__ \ (__| |  | | |_) | |_| (__\__ \
|___/\___|_|  |_| .__/ \__\\___|___/
                |_| Version: 0.14.0

c:\ > echo %errorlevel%
0
paul@ubuntu:~$ scriptcs a.csx
ERROR: Could not find file "/home/paul/a.csx". - '/home/paul/a.csx'.

paul@ubuntu:~$ echo $?
1

paul@ubuntu:~$ scriptcs -v
               _       _
 ___  ___ _ __(_)_ __ | |__ ___ ___
/ __|/ __| '__| | '_ \| __// __/ __|
\__ \ (__| |  | | |_) | |_| (__\__ \
|___/\___|_|  |_| .__/ \__\\___|___/
                |_| Version: 0.14.0

paul@ubuntu:~$ echo $?
0

@paulbouwer paulbouwer added the bug label Mar 30, 2015
@paulbouwer paulbouwer added this to the v0.4.1 milestone Mar 30, 2015
@adamralph
Copy link
Contributor Author

👍 great work @paulbouwer

I also retried my use case and 0.4.1 fixed it for me.

@adamralph
Copy link
Contributor Author

That error message from scriptcs.exe is, er, interesting scriptcs/scriptcs#1010

@paulbouwer
Copy link
Contributor

Yes - it is ... confusing 😄

@adamralph
Copy link
Contributor Author

Should be fixed in 0.15

On 03:51, Fri, 3 Apr 2015 Paul Bouwer notifications@github.com wrote:

Yes - it is ... confusing [image: 😄]


Reply to this email directly or view it on GitHub
#67 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants