Implement UUID Column Type #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybczak
reviewed
Oct 31, 2019
hpqtypes-extras.cabal
Outdated
| @@ -109,4 +110,5 @@ test-suite hpqtypes-extras-tests | |||
| tasty, | |||
| tasty-hunit, | |||
| text, | |||
| transformers | |||
| transformers, | |||
| uuid | |||
There was a problem hiding this comment.
It looks like this isn't needed.
There was a problem hiding this comment.
UUID is needed in the tests. I have removed the dependency in main and updated the tests to use uuid-types.
|
LGTM apart from redundant dependency, thanks! We'll make a release once fields-json 0.4.0.0 sits on hackage. Can you bump fields-json dependency to |
Done |
arybczak
force-pushed
the
dev-soares-pq-uuid
branch
from
4d31e32
to
8168bf1
Compare
|
I force-pushed the branch with fixed release date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
UuidTcolumn type which makes use of the UUID format implemented in scrive/hpqtypes#17.It also modifies the existing test to make use of the UUID type instead of regular integer. The alternative is to have a mix of INT and UUID when testing some of the tables. Otherwise I can write separate tests just for UUID.
This change is