Add support for defining maximum log level #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsynacek
commented
Jul 1, 2021
log-base/src/Log/Data.hs
Outdated
| @@ -40,6 +41,9 @@ showLogLevel LogAttention = "attention" | |||
| showLogLevel LogInfo = "info" | |||
| showLogLevel LogTrace = "trace" | |||
|
|
|||
| defaultLogLevel :: LogLevel | |||
| defaultLogLevel = LogTrace | |||
There was a problem hiding this comment.
Should probably be LogInfo.
jsynacek
commented
Jul 23, 2021
log-base/src/Log/Logger.hs
Outdated
| @@ -32,6 +32,7 @@ data LoggerEnv = LoggerEnv | |||
| , leDomain :: ![T.Text] -- ^ Current application domain. | |||
| , leData :: ![A.Pair] -- ^ Additional data to be merged with the log | |||
| -- message\'s data. | |||
| , leMaxLogLevel :: LogLevel -- ^ The maximum log level to be logged. | |||
There was a problem hiding this comment.
To make things very clear that it's the maximum (not minimum) allowed level, we should probably add a note to where LogLevel is defined and explicitly mention that it derives Ord. And the order in which the constructors are defined then implies which one is actually of "the highest value" and also the most verbose.
jsynacek
force-pushed
the
dev-jsynacek-core3483-max-loglevel
branch
from
158c1fc
to
2d90447
Compare
arybczak
reviewed
Sep 24, 2021
| @@ -40,6 +44,9 @@ showLogLevel LogAttention = "attention" | |||
| showLogLevel LogInfo = "info" | |||
| showLogLevel LogTrace = "trace" | |||
|
|
|||
| defaultLogLevel :: LogLevel | |||
There was a problem hiding this comment.
You can add a haddock comment that it's LogInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.