Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aeson 2.0.1.0 #79

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Add support for aeson 2.0.1.0 #79

merged 1 commit into from
Feb 7, 2022

Conversation

JakubBarta
Copy link
Contributor

No description provided.

jsynacek
jsynacek reviewed Jan 20, 2022
View reviewed changes
Copy link
Contributor

@jsynacek jsynacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ugly, but I guess it's fine in this case. What might be slightly better to do is to hide all the CPP stuff into a separate "compat" module. I don't think it's necessary, though, so I guess it's up to Andrzej to decide.

@arybczak
Copy link
Collaborator

I think it should be possible to create a compat module and contain all the CPP inside of it.

It would re-export either Data.Aeson.KeyMap or Data.HashMap.Strict, define type synonym for KeyMap for the old version and define keyFromText, looks like this should be enough.

Then the same module can be used internally for scrive/unjson#19.

@JakubBarta sounds reasonable?

@JakubBarta
Copy link
Contributor Author

sounds good, on it

@JakubBarta
Copy link
Contributor Author

@arybczak @jsynacek done

@arybczak arybczak force-pushed the add-support-for-aeson-2.0.1.0 branch from d74f245 to 6c011dd Compare February 7, 2022 16:53
@arybczak arybczak force-pushed the add-support-for-aeson-2.0.1.0 branch from 6c011dd to 1f560e8 Compare February 7, 2022 21:54
@arybczak arybczak merged commit 676402a into master Feb 7, 2022
@arybczak arybczak deleted the add-support-for-aeson-2.0.1.0 branch February 7, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybczak arybczak Awaiting requested review from arybczak

@jsynacek jsynacek Awaiting requested review from jsynacek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakubBarta @arybczak @jsynacek