Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support alternative gas token #124

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

yiweichi
Copy link
Member

Purpose or design rationale of this PR

  1. to support use alternative gas token
  2. when using alternative gas token instead of Ether, check gas token balance of gasTokenGateway contract instead of Ether balance of scrollMessenger contracts

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.82%. Comparing base (f520420) to head (ede1be0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   40.82%   40.82%           
=======================================
  Files           5        5           
  Lines         605      605           
=======================================
  Hits          247      247           
  Misses        349      349           
  Partials        9        9           
Flag Coverage Δ
chain-monitor 40.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

colinlyguo
colinlyguo previously approved these changes Aug 15, 2024
georgehao
georgehao previously approved these changes Aug 15, 2024
@yiweichi yiweichi dismissed stale reviews from georgehao and colinlyguo via ede1be0 August 19, 2024 07:51
@yiweichi yiweichi merged commit 5accd3b into main Aug 19, 2024
4 checks passed
@yiweichi yiweichi deleted the feat-alternative-gas-token branch August 19, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants