Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: consider l1 data fee in txpool costcap #681

Merged
merged 4 commits into from
Mar 26, 2024
Merged

feat: consider l1 data fee in txpool costcap #681

merged 4 commits into from
Mar 26, 2024

Conversation

colinlyguo
Copy link
Member

1. Purpose or design rationale of this PR

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@colinlyguo colinlyguo requested a review from vyzo March 26, 2024 12:57
@colinlyguo colinlyguo mentioned this pull request Mar 26, 2024
Merged
13 tasks
vyzo
vyzo reviewed Mar 26, 2024
View reviewed changes
Copy link

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you abstract it somewhat? Too much errorprone repetition.

@colinlyguo colinlyguo force-pushed the feat/consider-l1-data-fee-in-txpool-costcap branch from 155a5f5 to a63f5f5 Compare March 26, 2024 15:43
@colinlyguo colinlyguo requested a review from vyzo March 26, 2024 15:46
@colinlyguo
Copy link
Member Author

can you abstract it somewhat? Too much errorprone repetition.

now it's simplified.

vyzo
vyzo approved these changes Mar 26, 2024
View reviewed changes
Copy link

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinlyguo colinlyguo merged commit 8d383fb into feat/l1-data-fee-toctou Mar 26, 2024
5 of 6 checks passed
@colinlyguo colinlyguo deleted the feat/consider-l1-data-fee-in-txpool-costcap branch March 26, 2024 16:32
Thegaram added a commit that referenced this pull request Mar 27, 2024
@vyzo @colinlyguo
@Thegaram @georgehao
fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecuta…
d1e4b59 
…bles (#627)

* Check L1DataFee in txpool promoteExecutables

* bump version

* implement L1 data fee in demoteUnexecutables as well

* Update core/tx_list.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* feat: consider l1 data fee in txpool costcap (#681)

* feat(txpool): consider l1 data fee in costcap

* fix CI

* simplify logic

* remove one db read op

* bump version

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
0xmountaintop pushed a commit that referenced this pull request Jul 31, 2024
@vyzo @colinlyguo
@Thegaram @georgehao @0xmountaintop
fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecuta…
d35f48f 
…bles (#627)

* Check L1DataFee in txpool promoteExecutables

* bump version

* implement L1 data fee in demoteUnexecutables as well

* Update core/tx_list.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* feat: consider l1 data fee in txpool costcap (#681)

* feat(txpool): consider l1 data fee in costcap

* fix CI

* simplify logic

* remove one db read op

* bump version

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
@0xmountaintop 0xmountaintop mentioned this pull request Jul 31, 2024
Merged
0xmountaintop pushed a commit that referenced this pull request Aug 1, 2024
@vyzo @colinlyguo
@Thegaram @georgehao @0xmountaintop
fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecuta…
d025bfe 
…bles (#627)

* Check L1DataFee in txpool promoteExecutables

* bump version

* implement L1 data fee in demoteUnexecutables as well

* Update core/tx_list.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* feat: consider l1 data fee in txpool costcap (#681)

* feat(txpool): consider l1 data fee in costcap

* fix CI

* simplify logic

* remove one db read op

* bump version

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
0xmountaintop pushed a commit that referenced this pull request Aug 1, 2024
@vyzo @colinlyguo
@Thegaram @georgehao @0xmountaintop
fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecuta…
a3fee98 
…bles (#627)

* Check L1DataFee in txpool promoteExecutables

* bump version

* implement L1 data fee in demoteUnexecutables as well

* Update core/tx_list.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* feat: consider l1 data fee in txpool costcap (#681)

* feat(txpool): consider l1 data fee in costcap

* fix CI

* simplify logic

* remove one db read op

* bump version

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
0xmountaintop pushed a commit that referenced this pull request Aug 2, 2024
@vyzo @colinlyguo
@Thegaram @georgehao @0xmountaintop
fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecuta…
0bf32dd 
…bles (#627)

* Check L1DataFee in txpool promoteExecutables

* bump version

* implement L1 data fee in demoteUnexecutables as well

* Update core/tx_list.go

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* Update core/tx_pool.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* feat: consider l1 data fee in txpool costcap (#681)

* feat(txpool): consider l1 data fee in costcap

* fix CI

* simplify logic

* remove one db read op

* bump version

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
0xmountaintop added a commit that referenced this pull request Aug 2, 2024
@0xmountaintop @vyzo
@colinlyguo @Thegaram @georgehao
fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecuta…
58ed1a2 
…bles (#948)

fix: Check L1DataFee in txpool promoteExecutables and demoteUnexecutables (#627)

* Check L1DataFee in txpool promoteExecutables

* bump version

* implement L1 data fee in demoteUnexecutables as well

* Update core/tx_list.go



* Update core/tx_pool.go



* feat: consider l1 data fee in txpool costcap (#681)

* feat(txpool): consider l1 data fee in costcap

* fix CI

* simplify logic

* remove one db read op

* bump version

---------

Co-authored-by: vyzo <vyzo@hackzen.org>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: georgehao <haohongfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinlyguo @vyzo