Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to latest develop + new mpt circuit #151

Merged
merged 8 commits into from
Jun 27, 2023
Merged

switch to latest develop + new mpt circuit #151

merged 8 commits into from
Jun 27, 2023

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Jun 20, 2023

when make mock, some constrains failed:

(1) mpt lookup related. @z2trillion
(2) l1 fee related @noel2004
(3) pi circuit @kunxian-xia (using develop@zkevm-circuit also reports this err). It is possible to log::error more details early during assignment? need to set COINBASE env var
(4) COINBASE=5300000000000000000000000000000000000005 RUST_LOG=debug cargo test --features prove_verify --release test_vk_same -- --exact --nocapture 2>&1 | tee vk.log. The constant column of pi circuit, and the second last fixed column of zktrie circuit, is not fixed.

@z2trillion
Copy link
Member

when make mock, some constrains failed:

(1) mpt lookup related. @z2trillion (2) l1 fee related @noel2004

scroll-tech/mpt-circuit#50 addresses (1)

@kunxian-xia
Copy link
Contributor

These two errors are caused by not setting "COINBASE". There are two options for setting the env-var that come to my mind:

  1. set it in some script to run prover;
  2. put it in a file (maybe .env file?).

What do you think the best way to set the env var?

@lispc lispc changed the title switch to new mpt circuit switch to latest develop + new mpt circuit Jun 26, 2023
@kunxian-xia
Copy link
Contributor

The bug in which the constant column of PI circuit is not fixed shall be fixed by this PR(scroll-tech/zkevm-circuits#561).

@noel2004
Copy link
Member

It seems that we still have no fixed assignment for index and modulus_byte col: @z2trillion

https://github.com/scroll-tech/mpt-circuit/blob/f47013661d95de36be030dcb1afbf66349c27533/src/gadgets/canonical_representation.rs#L147

@noel2004
Copy link
Member

when make mock, some constrains failed:

(1) ~mpt lookup related. @z2trillion ~ (2) ~ l1 fee related @noel2004 ~ (3) ~pi circuit @kunxian-xia (using develop@zkevm-circuit also reports this err). It is possible to log::error more details early during assignment? ~ need to set COINBASE env var (4) COINBASE=5300000000000000000000000000000000000005 RUST_LOG=debug cargo test --features prove_verify --release test_vk_same -- --exact --nocapture 2>&1 | tee vk.log. The constant column of pi circuit, and the second last fixed column of zktrie circuit, is not fixed.

scroll-tech/mpt-circuit#52 should fix the unfixed column in zktrie circuit

@lispc lispc marked this pull request as ready for review June 27, 2023 13:49
@lispc lispc merged commit 0ca5710 into main Jun 27, 2023
@lispc lispc deleted the feat/new-mpt branch June 27, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants