-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to latest develop + new mpt circuit #151
Conversation
scroll-tech/mpt-circuit#50 addresses (1) |
These two errors are caused by not setting "COINBASE". There are two options for setting the env-var that come to my mind:
What do you think the best way to set the env var? |
The bug in which the constant column of PI circuit is not fixed shall be fixed by this PR(scroll-tech/zkevm-circuits#561). |
It seems that we still have no fixed assignment for |
scroll-tech/mpt-circuit#52 should fix the unfixed column in zktrie circuit |
when
make mock
, some constrains failed:(1)
mpt lookup related. @z2trillion(2)
l1 fee related @noel2004(3)
pi circuit @kunxian-xia (using develop@zkevm-circuit also reports this err). It is possible to log::error more details early during assignment?need to set COINBASE env var(4) COINBASE=5300000000000000000000000000000000000005 RUST_LOG=debug cargo test --features prove_verify --release test_vk_same -- --exact --nocapture 2>&1 | tee vk.log. The constant column of pi circuit, and the second last fixed column of zktrie circuit, is not fixed.