Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate row consumption into chunk-proposer #647

Merged
merged 60 commits into from
Aug 3, 2023

Conversation

NazariiDenha
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

This PR integrates RowConsumption API into chunk-proposer and db and applies constraints
https://www.notion.so/scrollzkp/Constraints-on-Chunk-Batch-Proposers-92d12a4a4ae64a63b37354a231a4b5d4

https://app.asana.com/0/1202293017617135/1205010572548774/f

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@NazariiDenha NazariiDenha changed the title feat: integrate row consumption into chunk-proposer (WIP)feat: integrate row consumption into chunk-proposer Jul 14, 2023
@NazariiDenha NazariiDenha marked this pull request as ready for review July 14, 2023 16:19
bridge/conf/config.json Outdated Show resolved Hide resolved
@NazariiDenha
Copy link
Contributor Author

need to update all l2geth versions and docker image

@NazariiDenha NazariiDenha marked this pull request as draft July 24, 2023 14:32
@NazariiDenha NazariiDenha marked this pull request as ready for review July 26, 2023 13:06
@NazariiDenha NazariiDenha marked this pull request as draft July 26, 2023 14:29
@0xmountaintop 0xmountaintop changed the title (WIP)feat: integrate row consumption into chunk-proposer feat: integrate row consumption into chunk-proposer Aug 3, 2023
@0xmountaintop 0xmountaintop merged commit f44ec75 into develop Aug 3, 2023
19 of 20 checks passed
@0xmountaintop 0xmountaintop deleted the feat/row-consumption-limit branch August 3, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants