-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate row consumption into chunk-proposer #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NazariiDenha
changed the title
feat: integrate row consumption into chunk-proposer
(WIP)feat: integrate row consumption into chunk-proposer
Jul 14, 2023
colinlyguo
reviewed
Jul 17, 2023
colinlyguo
reviewed
Jul 17, 2023
…-consumption-limit
…-consumption-limit
need to update all |
…-consumption-limit
…croll into feat/row-consumption-limit
0xmountaintop
changed the title
(WIP)feat: integrate row consumption into chunk-proposer
feat: integrate row consumption into chunk-proposer
Aug 3, 2023
Thegaram
approved these changes
Aug 3, 2023
0xmountaintop
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
This PR integrates
RowConsumption API
intochunk-proposer
anddb
and applies constraintshttps://www.notion.so/scrollzkp/Constraints-on-Chunk-Batch-Proposers-92d12a4a4ae64a63b37354a231a4b5d4
https://app.asana.com/0/1202293017617135/1205010572548774/f
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?