Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(coordinator & prover): RESTful API #696

Merged
merged 41 commits into from
Aug 5, 2023

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 1, 2023

Purpose or design rationale of this PR

What does this PR do?

This PR optimizes the communication between coordinator and prover.

Why does it do it?

  1. Currently, the coordinator can't deploy multiple replicas, for high availability, we need to enhance it.
  2. Changed prover client to support RESTful API according to coordinator refactor.

How does it do it?

Design doc: https://www.notion.so/scrollzkp/Proposal-Interactive-mode-for-coordinator-and-prover-f4340330f37743ebab796c6e20f972b2

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo self-assigned this Aug 1, 2023
@colinlyguo colinlyguo force-pushed the pull-model-prover-client branch 4 times, most recently from c0fc89b to 2396dc7 Compare August 1, 2023 12:45
@colinlyguo colinlyguo changed the title [WIP] new prover client [WIP] refactor(prover): RESTful client Aug 1, 2023
@colinlyguo colinlyguo marked this pull request as ready for review August 1, 2023 18:36
@colinlyguo colinlyguo changed the base branch from develop to feat/restful-api-for-prover August 2, 2023 08:02
@colinlyguo colinlyguo changed the base branch from feat/restful-api-for-prover to develop August 2, 2023 08:15
@colinlyguo colinlyguo changed the title [WIP] refactor(prover): RESTful client refactor(prover): RESTful client Aug 2, 2023
@colinlyguo colinlyguo changed the base branch from develop to RESTful-coordinator-prover August 2, 2023 08:39
prover/client/client.go Outdated Show resolved Hide resolved
prover/client/client.go Outdated Show resolved Hide resolved
prover/client/client.go Show resolved Hide resolved
prover/client/types.go Outdated Show resolved Hide resolved
prover/client/types.go Show resolved Hide resolved
prover/client/types.go Outdated Show resolved Hide resolved
@georgehao georgehao marked this pull request as ready for review August 4, 2023 12:51
@colinlyguo colinlyguo changed the title refactor(prover): RESTful client refactor(coordinator & prover): RESTful APIs Aug 4, 2023
@colinlyguo colinlyguo changed the title refactor(coordinator & prover): RESTful APIs refactor(coordinator & prover): RESTful API Aug 4, 2023
@Thegaram
Copy link
Contributor

Thegaram commented Aug 5, 2023

Merging now so that we can deploy and test.

@Thegaram Thegaram merged commit 2a0c7ae into develop Aug 5, 2023
17 checks passed
@Thegaram Thegaram deleted the pull-model-prover-client branch August 5, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants