Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): OZ-N04 Implicit Type Casting #907

Merged
merged 2 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/src/rate-limiter/ETHRateLimiter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ contract ETHRateLimiter is Ownable, IETHRateLimiter {
uint256 _currentTotalAmount;
ETHAmount memory _currentPeriod = currentPeriod;

if (_currentPeriod.lastUpdateTs < _currentPeriodStart) {
if (uint256(_currentPeriod.lastUpdateTs) < _currentPeriodStart) {
_currentTotalAmount = _amount;
} else {
_currentTotalAmount = _currentPeriod.amount + _amount;
Expand Down
2 changes: 1 addition & 1 deletion contracts/src/rate-limiter/TokenRateLimiter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ contract TokenRateLimiter is AccessControlEnumerable, ITokenRateLimiter {
// check total limit, `0` means no limit at all.
uint256 _currentTotalAmount;
TokenAmount memory _currentPeriod = currentPeriod[_token];
if (_currentPeriod.lastUpdateTs < _currentPeriodStart) {
if (uint256(_currentPeriod.lastUpdateTs) < _currentPeriodStart) {
_currentTotalAmount = _amount;
} else {
_currentTotalAmount = _currentPeriod.amount + _amount;
Expand Down
Loading