Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover, coordinator): update vk handling logic #931

Merged
merged 8 commits into from
Sep 7, 2023

Conversation

0xmountaintop
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #931 (46d5d7c) into develop (2b6a3c9) will not change coverage.
The diff coverage is n/a.

❗ Current head 46d5d7c differs from pull request most recent head 7f1d009. Consider uploading reports for the commit 7f1d009 to get more accurate results

@@           Coverage Diff            @@
##           develop     #931   +/-   ##
========================================
  Coverage    49.39%   49.39%           
========================================
  Files           95       95           
  Lines         9949     9949           
========================================
  Hits          4914     4914           
  Misses        4620     4620           
  Partials       415      415           
Flag Coverage Δ
common 54.56% <ø> (ø)
coordinator 18.94% <ø> (ø)
database 42.85% <ø> (ø)
prover 27.32% <ø> (ø)
rollup 63.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@0xmountaintop 0xmountaintop force-pushed the libzkp-v0.8.x-upgrade_logic branch 5 times, most recently from 1d2113b to 138ab68 Compare September 6, 2023 04:33
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

LCOV of commit d74b4c6 during Contracts #18

Summary coverage rate:
  lines......: 51.2% (996 of 1946 lines)
  functions..: 65.2% (223 of 342 functions)
  branches...: no data found

Files changed coverage rate: n/a

Base automatically changed from libzkp-v0.8.x to develop September 7, 2023 02:34
@0xmountaintop 0xmountaintop changed the title WIP: update vk handling logic feat(prover, coordinator): update vk handling logic Sep 7, 2023
@0xmountaintop 0xmountaintop added the bump-version Bump the version tag for deployment label Sep 7, 2023
@scroll-dev scroll-dev merged commit cd456ee into develop Sep 7, 2023
@scroll-dev scroll-dev deleted the libzkp-v0.8.x-upgrade_logic branch September 7, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants