Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Location List Issue - Vim 7.4, patches 1-1707 #1738

Closed
amadeus opened this issue Apr 4, 2016 · 9 comments
Closed

Location List Issue - Vim 7.4, patches 1-1707 #1738

amadeus opened this issue Apr 4, 2016 · 9 comments

Comments

@amadeus
Copy link

amadeus commented Apr 4, 2016

I am using the latest version of Vim, built from source, and the location list appears broken when attempting to use it to jump to a location of an error/warning returned from ESLint.

When I press enter on a line in the location list, my cursor just returns to the last position it was in the buffer before I jumped to the location list split.

I also get an error:

E926: Current location list was changed

Not sure if this is an issue Vim needs to fix, or if they changed something with how location lists are handled and Syntastic needs a fix.

@n8henrie
Copy link

n8henrie commented Apr 5, 2016

👍 http://superuser.com/questions/1059194/vim-syntastic-not-jumping-to-the-error

Something definitely changed with vim; old versions are working fine. Also lnext and lprev still work, just not selecting from the list.

I haven't seen any vim issues raised on it yet.

@lcd047
Copy link
Collaborator

lcd047 commented Apr 5, 2016

Yes, this behaviour was introduced by Vim 7.4.1592, but it isn't clear the bug is in Vim, or that it should be addressed there. The patch 1592 is a bug fix, and it solves a real crash. On the other hand, what syntastic does on the relevant code path is a mess, and it's definitely wrong in some scenarios. I made several attempts over the years to fix this, but the limitations in Vim's API basically mean that fixing some scenario breaks others. Until patch 1592 the broken scenarios were just less common. I'll try again, but I'm not particularly confident the result is going to be substantially better this time. shrug

@lcd047
Copy link
Collaborator

lcd047 commented Apr 5, 2016

Duplicate of #1127.

@lcd047
Copy link
Collaborator

lcd047 commented Apr 7, 2016

Please try 7e986f1 and report any problems. Segfaults might be on the plate too (well, hopefully not).

@amadeus
Copy link
Author

amadeus commented Apr 7, 2016

I am testing it out, so far it seems to work great, thanks!

@n8henrie
Copy link

Sorry for the late reply -- working flawlessly for me on vim 7.4.1707.

@luan
Copy link

luan commented Apr 12, 2016

@lcd047 I'm getting this error when opening a file for the first time through the locationlist:

Error detected while processing function <SNR>114_BufEnterHook[5]..342[20]..269[2]..270[5]..330[2]..329:
line    8:
E121: Undefined variable: b:syntastic_changedtick
Press ENTER or type command to continue
Error detected while processing function <SNR>114_BufEnterHook[5]..342[20]..269[2]..270[5]..330[2]..329:
line    8:
E15: Invalid expression: [bufnr(''), b:syntastic_changedtick]
Press ENTER or type command to continue
E926: Current location list was changed
Press ENTER or type command to continue

@lcd047
Copy link
Collaborator

lcd047 commented Apr 12, 2016

@luan Right, please upgrade to d9814c5.

@lcd047
Copy link
Collaborator

lcd047 commented May 1, 2016

Not fixed, see the end of #1127 for updates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants