This repository has been archived by the owner on Nov 26, 2022. It is now read-only.
Normalize timestamps before comparison. #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Randy, thanks for your PR. Can I please ask you to change the base branch from enigma:develop to enigma:rc-0.1.dev7 ? I tried to do it, but I don't think I can. For you it should only be a click away as per https://github.com/blog/2224-change-the-base-branch-of-a-pull-request. Thank you and sorry for the inconvenience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Must normalize the pandas timestamps before comparison.
Making this PR against develop. Let me know if you prefer to see it against the master.