Skip to content
This repository has been archived by the owner on Jul 19, 2020. It is now read-only.

BLD: updated CI and integration with docker-environment #52

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

lacabra
Copy link
Contributor

@lacabra lacabra commented Jan 30, 2020

This is an opinionated PR that restructures how this repo integrates with docker-environment, and how the CI runs.

  • Like all other repos in the Enigma Protocol (see core, contract and p2p, the definition and building of docker images is externalized and centralized into the docker-environment repo.
  • Local copies of docker-compose.yml have been updated from the latest copy in docker-environment
  • In the CI, the images for salad_operator and salad_client are built from docker-environment using the current branch from this repo. Because Github CI does not provide the BRANCH environment variable, we have to parse it from the available $GITHUB_REF (see their documentation

@reuvenpo
Copy link
Contributor

I believe that just using $GITHUB_REF without modification should work too, but we need to check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants