Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create de_DE.json #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create de_DE.json #7

wants to merge 1 commit into from

Conversation

lablum
Copy link

@lablum lablum commented Jul 27, 2020

Finished german translation.

Finished german translation.
@AlexanderStohr
Copy link

AlexanderStohr commented Dec 1, 2020

I only browsed it quickly, but looks basically fine to me. (I am native German.)
I would like to see this merged, thanks.

@AlexanderStohr AlexanderStohr mentioned this pull request Dec 1, 2020
@AlexanderStohr
Copy link

considered a far more advanced follow up for pull request #5. thus this one replaces that older one.

@AlexanderStohr
Copy link

@scrumpypoker - what's your opinion on this?

@scrumpypoker
Copy link
Owner

Hello @AlexanderStohr , thank you very much for contributing! It looks great with one small issue - it seems the texts that are not translated are deleted. We don't have the tooling yet to fall back to English and instead we'd expect the missing text to be left intact, in the same order as the English text. This way we can use the en_US.json as a source of truth and check what has been translated and how it was translated with simple text diff. Those instructions are in the readme of the project btw. Can you please 'merge' the en_US.json and preserve the order? After that we'll include this in the next release even though it seems about 100 entries are not yet translated. It would be great if there is a follow up PR after that for the rest of the text.

As you might have noticed, the Jira add-ons are becoming paid which will allow us to have more budget on the translation tooling and certainly bounties for our current and future translation contributors - some time around March 2021.

Thanks again for helping us!

@AlexanderStohr
Copy link

i suspected that a little bit of "merge & check" tooling is needed due to out of sync file state - seen similar things in other projects.
lets see if i have the time for looking after that in coming weekend or earlier.

@stefanwendelmann
Copy link

Any efforts @AlexanderStohr ?
May i help here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants