New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup & reorganization #73

Merged

jonasstein merged 1 commit into scsitape:master from jmwilson:cleanup2

May 16, 2022

Contributor

jmwilson commented May 15, 2022

scsi::get_des & others should take a non-const buffer since they modify it
Reorder functions in main.cpp to declare internal functions static
Fix compile error in newer GCC (Compilation error #72) with more explicit cast
Remove some unused constants
Add KAD type enum
Pass key vector by reference instead of copying


          Cleanup & reorganization

318e006

jonasstein reviewed

View reviewed changes

src/main.cpp

               {
                 auto it = s.data();
-                std::vector<uint8_t> bytes;
+                std::vector<std::uint8_t> bytes;

Collaborator

jonasstein May 16, 2022

lets rename "bytes" to something more meaningful later.

jonasstein merged commit 8caaf85 into scsitape:master

jmwilson deleted the cleanup2 branch

June 6, 2022 05:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet