Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating movies when checking credits. #504

Closed
pairofcrocs opened this issue Dec 26, 2020 · 5 comments
Closed

Repeating movies when checking credits. #504

pairofcrocs opened this issue Dec 26, 2020 · 5 comments

Comments

@pairofcrocs
Copy link

Describe the bug
Repeating movies when checking credits.

What version of Overseerr are you running?
v1.14.0

To Reproduce
Clicking Director, Screenplay, etc. inside of movie to see other films that they've worked on, brings up multiple repeats of the same movie.

Expected behavior
It should just show each film once.

bug

@sct
Copy link
Owner

sct commented Dec 26, 2020

It's not really a bug. They have credits for multiple things. The question is, if we combine them, how do we best display all of the roles?

@pairofcrocs
Copy link
Author

I guess that's technically true, but if you're looking at their credits, you don't really need to se multiple of the same movie. I think it would be safe to say that only having one instance from each movie would make most sense.

@sct
Copy link
Owner

sct commented Dec 27, 2020

I agree. I just don't want to hide roles the person has. So I will think about how to best display them then we can work on combining the duplicates.

@sct
Copy link
Owner

sct commented Dec 27, 2020

Okay this is merged into develop. I am just combining the credits into a single string that is being truncated. We may be able to improve how we display this in the future, but for now it's good enough I think!

@github-actions
Copy link

github-actions bot commented Jan 4, 2021

🎉 This issue has been resolved in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants