fix(user edit): fix user edit not being able to be saved #651
Conversation
src/components/UserEdit/index.tsx
Outdated
| @@ -80,6 +80,7 @@ const UserEdit: React.FC = () => { | |||
| permissions: currentPermission, | |||
| email: user?.email, | |||
| avatar: user?.avatar, | |||
| userType: user?.userType, | |||
There was a problem hiding this comment.
I don't think we should pass user type. It shouldn't be editable by the user anyways. We should instead change the user route on the server end to merge the actual editable values being submitted.
There was a problem hiding this comment.
Don't the same apply for email and avatar though?
There was a problem hiding this comment.
Avatar yes, email will be editable for local users. So no.
At some point we could also make avatars editable but not very important.
There was a problem hiding this comment.
Hm ok. I see your point then.
The issue is not that it isn't merging the result I think, but that the User schema lists userType as a required parameter.
There was a problem hiding this comment.
Oh, yeah. Ok let's get this merged for now and we can refactor it later.
The local user commit introduced a bug that made you unable to save edited users
Didn't supply the needed attributes for either one, so react put an error in the console
ankarhem
force-pushed
the
fix-user-edit-error
branch
from
0c04b1c
to
49e121d
Compare
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
The local user commit introduced a bug that made you unable to save edited users
also fixed another error that was on the user edit page