Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Add missing source strings & remove local user sign-in setting tip #828

Merged
merged 2 commits into from
Feb 3, 2021
Merged

fix(lang): Add missing source strings & remove local user sign-in setting tip #828

merged 2 commits into from
Feb 3, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Feb 3, 2021

Description

A few strings were missing from my earlier PR, sorry! Also, removed the unused "ms" string.

Edit: Remove the local user sign-in setting tip as well, since it was found to be confusing.

Screenshot (if UI related)

N/A

Todos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

@TheCatLady TheCatLady changed the title fix(lang): Add missing source strings fix(lang): Add missing source strings & remove local user sign-in setting tip Feb 3, 2021
@sct sct merged commit c0769d4 into sct:develop Feb 3, 2021
@TheCatLady TheCatLady deleted the add-missing-strings branch February 3, 2021 16:16
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants