-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): changed plex, request, and cog buttons to align proper… #928
Conversation
0431f7a
to
3f41760
Compare
8841903
to
59611a2
Compare
What is the reasoning behind the changes in 59611a2? There are other elements that would also need to be updated as a result of those new changes. |
I asked him to change it to this because I didn't like the buttons going to the edge of the screen. They should respect the same margins the rest of the site has. What other components would need to change? |
Ah I see. We also need to apply the same margins from the "Play on Plex" button to the |
I changed the margin on the div wrapping the three buttons so they will stay the same on one line. |
I just pulled your changes to get a better look. I see what you did now. LGTM! |
🎉 This PR is included in version 1.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…ly on smaller mobile UIs
Description
Play on plex/watch trailer, request, and settings cog buttons would break on a smaller mobile device such as an iPhone X. Also aligns media status with the poster.
Screenshot (if UI related)
Before:
After:
Todos
yarn build
yarn i18n:extract