feat(regions): add region setting for filtering Discover (#732) #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancarter
commented
Feb 15, 2021
dancarter
commented
Feb 15, 2021
dancarter
commented
Feb 15, 2021
dancarter
commented
Feb 15, 2021
dancarter
commented
Feb 15, 2021
TheCatLady
reviewed
Feb 15, 2021
TheCatLady
reviewed
Feb 15, 2021
TheCatLady
reviewed
Feb 15, 2021
|
Should this be a user setting instead of a global one? Or if it is a global setting, do we want to allow users the ability to override the setting? |
Initially it will be global and we will allow users to override the value as well. |
sct
force-pushed
the
732-discover-region-filter
branch
from
4c18733
to
9f94a52
Compare
TheCatLady
reviewed
Feb 21, 2021
sct
force-pushed
the
732-discover-region-filter
branch
from
97b503b
to
c7600ff
Compare
sct
force-pushed
the
732-discover-region-filter
branch
from
5b2094d
to
f645a11
Compare
|
@all-contributors please add @dancarter for code |
|
I've put up a pull request to add @dancarter! 🎉 |
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Default Region setting to the settings page that filters the Discover page
Screenshot (if UI related)
Todos
yarn buildyarn i18n:extractIssues Fixed or Closed by this PR