Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #2

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Fix warnings #2

merged 2 commits into from
Apr 23, 2018

Conversation

travistrue2008
Copy link

It appears that some warnings have surfaced due to some recent updates to BuckleScript. I went ahead, and addressed the deprecation warnings. All tests continue to run warning-free.

Copy link
Owner

@scull7 scull7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🇮🇹

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.284%

Totals Coverage Status
Change from base Build 11: 0.0%
Covered Lines: 278
Relevant Lines: 306

💛 - Coveralls

Copy link
Collaborator

@carmonw carmonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@scull7 scull7 merged commit 4e7bf97 into scull7:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants