Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All the Things #10

Merged
merged 6 commits into from
Jul 9, 2018
Merged

All the Things #10

merged 6 commits into from
Jul 9, 2018

Conversation

scull7
Copy link
Owner

@scull7 scull7 commented Jul 8, 2018 •
edited
Loading

  • Add an internal ID type to hide the Primary ID column type so we don't
    run into issues with BIGINT values being used as identifiers.
  • Remap the module interface to be more idiomatic.

Resolves #7

@scull7
All the Things
8b904a2 
- Add an internal ID type to hide the Primary ID column type so we don't
  run into issues with BIGINT values being used as identifiers.
- Remap the module interface to be more idiomatic.
@scull7 scull7 added bug Something isn't working enhancement New feature or request labels Jul 8, 2018
@scull7 scull7 requested a review from dvisztempacct July 8, 2018 07:24
@coveralls
Copy link

coveralls commented Jul 8, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 54

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 153
Relevant Lines: 153
💛 - Coveralls

@scull7 scull7 merged commit f6dd72c into master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvisztempacct dvisztempacct Awaiting requested review from dvisztempacct

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scull7 @coveralls