3
3
We would love for you to contribute to Scully and help make it even better than it is
4
4
today! As a contributor, here are the guidelines we would like you to follow:
5
5
6
- - [ Code of Conduct] ( #coc )
7
- - [ Question or Problem?] ( #question )
8
- - [ Issues and Bugs] ( #issue )
9
- - [ Feature Requests] ( #feature )
10
- - [ Submission Guidelines] ( #submit )
11
- - [ Coding Rules] ( #rules )
12
- - [ Commit Message Guidelines] ( #commit )
13
- - [ Signing the CLA] ( #signing-the-cla )
6
+ - [ Code of Conduct] ( #coc )
7
+ - [ Question or Problem?] ( #question )
8
+ - [ Issues and Bugs] ( #issue )
9
+ - [ Feature Requests] ( #feature )
10
+ - [ Submission Guidelines] ( #submit )
11
+ - [ Coding Rules] ( #rules )
12
+ - [ Commit Message Guidelines] ( #commit )
13
+ - [ Signing the CLA] ( #signing-the-cla )
14
14
15
15
## <a name =" coc " ></a > Code of Conduct
16
+
16
17
Help us keep Scully open and inclusive. Please read and follow our [ Code of Conduct] [ coc ] .
17
18
18
19
## <a name =" question " ></a > Got a Question or Problem?
@@ -30,20 +31,22 @@ To save your and our time, we will systematically close all issues that are requ
30
31
If you would like to chat about the question in real-time, you can reach out via our gitter channel (Coming soon).
31
32
32
33
## <a name =" issue " ></a > Found a Bug?
34
+
33
35
If you find a bug in the source code, you can help us by
34
36
[ submitting an issue] [ github-issue ] to our [ GitHub Repository] [ github ] . Even better, you can
35
37
[ submit a Pull Request] ( #submit-pr ) with a fix.
36
38
37
39
## <a name =" feature " ></a > Missing a Feature?
38
- You can * request* a new feature by [ submitting an issue] ( #submit-issue ) to our GitHub
39
- Repository. If you would like to * implement* a new feature, please submit an issue with
40
+
41
+ You can _ request_ a new feature by [ submitting an issue] ( #submit-issue ) to our GitHub
42
+ Repository. If you would like to _ implement_ a new feature, please submit an issue with
40
43
a proposal for your work first, to be sure that we can use it.
41
44
Please consider what kind of change it is:
42
45
43
- * For a ** Major Feature** , first open an issue and outline your proposal so that it can be
44
- discussed. This will also allow us to better coordinate our efforts, prevent duplication of work,
45
- and help you to craft the change so that it is successfully accepted into the project.
46
- * ** Small Features** can be crafted and directly [ submitted as a Pull Request] ( #submit-pr ) .
46
+ - For a ** Major Feature** , first open an issue and outline your proposal so that it can be
47
+ discussed. This will also allow us to better coordinate our efforts, prevent duplication of work,
48
+ and help you to craft the change so that it is successfully accepted into the project.
49
+ - ** Small Features** can be crafted and directly [ submitted as a Pull Request] ( #submit-pr ) .
47
50
48
51
## <a name =" submit " ></a > Submission Guidelines
49
52
@@ -61,38 +64,40 @@ Unfortunately, we are not able to investigate / fix bugs without a minimal repro
61
64
62
65
You can file new issues by selecting from our [ new issue templates] [ github-choose ] and filling out the issue template.
63
66
64
-
65
67
### <a name =" submit-pr " ></a > Submitting a Pull Request (PR)
68
+
66
69
Before you submit your Pull Request (PR) consider the following guidelines:
67
70
68
71
1 . Search [ GitHub] ( https://github.com/scullyio/scully/pulls ) for an open or closed PR
69
- that relates to your submission. You don't want to duplicate effort.
72
+ that relates to your submission. You don't want to duplicate effort.
70
73
1 . Be sure that an issue describes the problem you're fixing, or documents the design for the feature you'd like to add.
71
- Discussing the design up front helps to ensure that we're ready to accept your work.
74
+ Discussing the design up front helps to ensure that we're ready to accept your work.
72
75
1 . Fork the scullyio/scully repo.
73
76
1 . Make your changes in a new git branch:
74
77
75
- ``` shell
76
- git checkout -b my-fix-branch master
77
- ```
78
+ ``` shell
79
+ git checkout -b my-fix-branch master
80
+ ```
78
81
79
82
1 . Create your patch, ** including appropriate test cases** .
80
83
81
84
1 . Commit your changes using a descriptive commit message that follows our
82
- [commit message conventions](# commit). Adherence to these conventions
83
- is necessary run the command ` npm run commit` (this add all the files using ` git add .` ) or
84
- if you need only add some files, you can need run the command ` npm run commit:select` .
85
+ [ commit message conventions] ( #commit ) . Adherence to these conventions
86
+ is necessary run the command ` npm run commit ` (this add all the files using ` git add . ` ) or
87
+ if you need only add some files, you can need run the command ` npm run commit:select ` .
85
88
86
89
1 . Push your branch to GitHub:
87
90
88
- ` ` ` shell
89
- git push origin my-fix-branch
90
- ` ` `
91
+ ``` shell
92
+ git push origin my-fix-branch
93
+ ```
91
94
92
95
1 . In GitHub, send a pull request to ` scully:master ` .
93
- * If we suggest changes then:
94
- * Make the required updates.
95
- * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
96
+
97
+ - If we suggest changes then:
98
+
99
+ - Make the required updates.
100
+ - Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
96
101
97
102
``` shell
98
103
git rebase master -i
@@ -106,41 +111,41 @@ That's it! Thank you for your contribution!
106
111
After your pull request is merged, you can safely delete your branch and pull the changes
107
112
from the main (upstream) repository:
108
113
109
- * Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:
114
+ - Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:
110
115
111
- ```shell
112
- git push origin --delete my-fix-branch
113
- ```
116
+ ```shell
117
+ git push origin --delete my-fix-branch
118
+ ```
114
119
115
- * Check out the master branch:
120
+ - Check out the master branch:
116
121
117
- ```shell
118
- git checkout master -f
119
- ```
122
+ ```shell
123
+ git checkout master -f
124
+ ```
120
125
121
- * Delete the local branch:
126
+ - Delete the local branch:
122
127
123
- ```shell
124
- git branch -D my-fix-branch
125
- ```
126
-
127
- * Update your master with the latest upstream version:
128
+ ```shell
129
+ git branch -D my-fix-branch
130
+ ```
128
131
129
- ```shell
130
- git pull --ff upstream master
131
- ```
132
+ - Update your master with the latest upstream version:
132
133
134
+ ```shell
135
+ git pull --ff upstream master
136
+ ```
133
137
134
138
## <a name="commit"></a> Commit Message Guidelines
135
139
136
- We have very precise rules over how our git commit messages can be formatted. This leads to **more
140
+ We have very precise rules over how our git commit messages can be formatted. This leads to **more
137
141
readable messages** that are easy to follow when looking through the **project history**.
138
142
139
143
### Commit Message Format
140
- Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
144
+
145
+ Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
141
146
format that includes a **type**, a **scope** and a **subject**:
142
147
143
- _The command `npm run commit` was previously configured to use all these rules_
148
+ _The command `npm run commit` was previously configured to use all these rules_
144
149
145
150
```
146
151
<type>(<scope>): <subject>
@@ -162,46 +167,51 @@ Samples from Angular Repository: (even more [samples](https://github.com/angular
162
167
```
163
168
docs(changelog): update changelog to beta.5
164
169
```
170
+
165
171
```
166
172
fix(release): need to depend on latest ng-lib
167
173
168
174
The version in our package.json gets copied to the one we publish, and users need the latest of these.
169
175
```
170
176
171
177
### Type
178
+
172
179
Must be one of the following:
173
180
174
- * **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
175
- * **docs**: Documentation only changes
176
- * **feat**: A new feature
177
- * **fix**: A bug fix
178
- * **perf**: A code change that improves performance
179
- * **refactor**: A code change that neither fixes a bug nor adds a feature
180
- * **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
181
- * **test**: Adding missing tests or correcting existing tests
181
+ - **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
182
+ - **docs**: Documentation only changes
183
+ - **feat**: A new feature
184
+ - **fix**: A bug fix
185
+ - **perf**: A code change that improves performance
186
+ - **refactor**: A code change that neither fixes a bug nor adds a feature
187
+ - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
188
+ - **test**: Adding missing tests or correcting existing tests
182
189
183
190
### Scope
191
+
184
192
The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages).
185
193
186
194
The following is the list of supported scopes:
187
195
188
- * **scully**
189
- * **ng-lib**
190
- * **schematics**
191
-
196
+ - **scully**
197
+ - **ng-lib**
198
+ - **schematics**
192
199
193
200
### Subject
201
+
194
202
The subject contains a succinct description of the change:
195
203
196
- * use the imperative, present tense: "change" not "changed" nor "changes"
197
- * don' t capitalize the first letter
198
- * no dot (.) at the end
204
+ - use the imperative, present tense: "change" not "changed" nor "changes"
205
+ - don' t capitalize the first letter
206
+ - no dot (.) at the end
199
207
200
208
# ## Body
209
+
201
210
Just as in the ** subject** , use the imperative, present tense: " change" not " changed" nor " changes" .
202
211
The body should include the motivation for the change and contrast this with previous behavior.
203
212
204
213
# ## Footer
214
+
205
215
The footer should contain any information about ** Breaking Changes** and is also the place to
206
216
reference GitHub issues that this commit ** Closes** .
207
217
@@ -214,7 +224,6 @@ Please sign our Contributor License Agreement (CLA) before sending pull requests
214
224
- For individuals we have a [simple click-through form][cla-individual].
215
225
- For corporations we' ll need you to [print, sign and one of scan+email, fax or mail the form][cla-corporations].
216
226
217
-
218
227
[coc]: https://github.com/scullyio/scully/blob/master/CODE_OF_CONDUCT.md
219
228
[github]: https://github.com/scullyio/scully
220
229
[github-issue]: https://github.com/scullyio/scully/issues/new? assignees=& labels=bug& template=---bug-report.md& title=
0 commit comments