Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't find a route declaration in /src/app/app.module.ts #36

Closed
IxquitilisSaid opened this issue Dec 17, 2019 · 7 comments
Closed

Couldn't find a route declaration in /src/app/app.module.ts #36

IxquitilisSaid opened this issue Dec 17, 2019 · 7 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@IxquitilisSaid
Copy link
Contributor

Since ng g @scullyio/init:blog requires a route declaration, should the Blog Doc contain an "observation" so the user has the AppRoutingModule import? Or is it not required and I'm missing something?

Have a great day and Team Scully all the way!

@jorgeucano
Copy link
Contributor

hey, have a great day you to @IxquitilisSaid !
Can you show me an example?

@IxquitilisSaid
Copy link
Contributor Author

Certainly! https://github.com/IxquitilisSaid/ScullyNoRouter

Steps taken

  • Generated new Angular Project with ng n script
  • On "Do you wish to add Angular Routing?" typed "n"
  • Ran ng add @scullyio/init
  • Ran ng g @scullyio/init:blog

Result: Couldn't find a route declaration in /src/app/app.module.ts.

To note: When I ran into this issue, I made a new project but included the Angular Router, which worked fine.

I can also include the one that worked if that helps 😄!

@jorgeucano
Copy link
Contributor

Ohhh the angular route is needed, that's the problem!
@Villanuevand Can you add this to the doc??

thanks!

@jorgeucano jorgeucano added documentation Improvements or additions to documentation and removed schematics need repo example labels Dec 17, 2019
@IxquitilisSaid
Copy link
Contributor Author

Makes sense since the scully.config needs the Routes object, but yeah, just a small bit of documentation missing 😜.

Also please let me know if I can help out with anything else, I'm really excited about this project and what's to come!

@jorgeucano
Copy link
Contributor

thanks @IxquitilisSaid, I think start to use it and check if you found bugs is the best option now for help us!

@SanderElias
Copy link
Contributor

@aaronfrost Do you think we need to add some more content/context to that error, aside form mentioning this in the documentation?

@SanderElias
Copy link
Contributor

SanderElias commented Dec 18, 2019

@IxquitilisSaid I'm closing this, because it works as designed.
However, we toke notes, and will update the docs and the error message to be more clear on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants