Skip to content

Commit e48ac17

Browse files
voltyasev-
authored andcommitted
PINK: small fixes
1 parent 475f6a6 commit e48ac17

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

engines/pink/file.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ bool OrbFile::open(const Common::String &name) {
7575
void OrbFile::loadGame(PinkEngine *game) {
7676
seekToObject("PinkGame");
7777
Archive archive(*this);
78-
archive.mapObject((Object *) game); // hack
78+
archive.mapObject(reinterpret_cast<Object*>(game)); // hack
7979
game->load(archive);
8080
}
8181

engines/pink/objects/handlers/handler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ void HandlerSequences::onMessage(LeadActor *actor) {
6565
Handler::onMessage(actor);
6666
Sequencer *sequencer = actor->getSequencer();
6767

68-
assert(_sequences.size());
68+
assert(!_sequences.empty());
6969

7070
Common::RandomSource &rnd = actor->getPage()->getGame()->getRnd();
7171
uint index = rnd.getRandomNumber(_sequences.size() - 1);

engines/pink/objects/module.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,9 @@ void Module::init(bool isLoadingSave, const Common::String &pageName) {
5050
// 0 0 - new game
5151
// 0 1 - module changed
5252
// 1 0 - from save
53-
if (!pageName.empty()) {
53+
if (!pageName.empty())
5454
_page = findPage(pageName);
55-
}
56-
57-
if (!_page)
55+
else if (!_page)
5856
_page = _pages[0];
5957

6058
_page->init(isLoadingSave);
@@ -67,7 +65,6 @@ void Module::changePage(const Common::String &pageName) {
6765

6866
//_page->clear
6967

70-
7168
page->init(kLoadingNewGame);
7269
}
7370

@@ -78,7 +75,6 @@ GamePage *Module::findPage(const Common::String &pageName) const {
7875
});
7976
}
8077

81-
8278
PinkEngine *Module::getGame() const {
8379
return _game;
8480
}

engines/pink/sound.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ Sound::Sound(Audio::Mixer *mixer, Common::SeekableReadStream *stream)
3434
}
3535

3636
Sound::~Sound() {
37-
//look for mem leak
3837
stop();
38+
delete _stream;
3939
}
4040

4141
bool Sound::isPlaying() {
@@ -64,7 +64,7 @@ void Sound::play(Audio::Mixer::SoundType type, int volume, bool isLoop) {
6464
_stream = Audio::makeLoopingAudioStream(seekableStream, 0, 0, 0);
6565
}
6666

67-
_mixer->playStream(type, &_handle ,_stream, -1 , Audio::Mixer::kMaxChannelVolume, 0,DisposeAfterUse::NO);
67+
_mixer->playStream(type, &_handle ,_stream, -1 , Audio::Mixer::kMaxChannelVolume, 0, DisposeAfterUse::NO);
6868
}
6969

7070
bool Sound::load(Common::SeekableReadStream *stream) {

0 commit comments

Comments
 (0)