Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postpone dtype deprecation #1137

Closed
gtca opened this issue Sep 11, 2023 · 1 comment · Fixed by #1153
Closed

Postpone dtype deprecation #1137

gtca opened this issue Sep 11, 2023 · 1 comment · Fixed by #1153
Assignees
Milestone

Comments

@gtca
Copy link

gtca commented Sep 11, 2023

Please describe your wishes and possible alternatives to achieve the desired result.

As v0.8 has been recommending to use dtype in the constructor (FutureWarning: X.dtype being converted to np.float32 from int64. In the next version of anndata (0.9) conversion will not be automatic. Pass dtype explicitly to avoid this warning. Pass AnnData(X, dtype=X.dtype, ...) to get the future behavour.), it might make the process a bit more gentle if the breaking changes associated with constructor arguments deprecation (#1126) can be postponed to a later release.

@ivirshup ivirshup added this to the 0.10.0 milestone Sep 17, 2023
@ivirshup
Copy link
Member

I would be up for this. I think having at least 2 feature releases/ or a year between deprecating a breaking change and making it is reasonable. It's only been 6 months since 0.9.

I will leave this open for a little more feedback, but am leaning towards postponing at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants