Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOFA: samples_names and samples_groups do not match if samples in AnnData are not sorted by group #14

Closed
bv2 opened this issue Nov 11, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bv2
Copy link
Collaborator

bv2 commented Nov 11, 2020

Example:
Samples in AnnData are sample1_group1, sample2_group1, sample1_group2, sample2_group2, sample3_group2, sample3_group1.

Resulting mofa samples_groups and samples_names
modal.data_opts['samples_groups'] = ["group1", "group1", "group2", "group2", "group2", "group1"]
modal.data_opts['samples_names'] = [["sample1_group1", "sample2_group1", "sample3_group1"],
["sample1_group2", "sample2_group2", "sample3_group2"]]

As samples_groups are concatenated later in entry_point.py the correspondence of samples to groups is wrong.

@bv2 bv2 added the bug Something isn't working label Nov 11, 2020
@gtca gtca closed this as completed in 4b895c6 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant