-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for cope with issue introduced in umap-learn 0.5.2 #2028
Conversation
As of umap-learn 0.5.2 an ``n_epochs`` value of 0 is now a valid value and None is used instead to indicate a value should be generated. To maintain forward compatability and backward compatibility with older umap-learn versions we instead make use of the epch setting criterion internal to umap-learn here directly. This should resolve issue scverse#2026 and lmcinnes/umap#798
Codecov Report
@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
+ Coverage 71.63% 71.64% +0.01%
==========================================
Files 92 92
Lines 11248 11252 +4
==========================================
+ Hits 8057 8062 +5
+ Misses 3191 3190 -1
|
Thanks! |
Thanks for the fix! I've just added a release note. |
…n 0.5.2 (#2033) Co-authored-by: Leland McInnes <leland.mcinnes@gmail.com>
As of umap-learn 0.5.2 an
n_epochs
value of 0 is now a valid value and None is used instead to indicate a value should be generated. To maintain forward compatability and backward compatibility with older umap-learn versions we instead make use of the epch setting criterion internal to umap-learn here directly. This should resolve issue #2026 and lmcinnes/umap#798